Thread (82 messages) 82 messages, 6 authors, 25d ago

Re: [GSoC][PATCH 4/4] repo: add path.commondir with absolute and relative suffix formatting

From: Lucas Seiki Oshiro <hidden>
Date: 2026-06-01 21:58:51

quoted hunk ↗ jump to hunk
diff --git a/t/t1900-repo-info.sh b/t/t1900-repo-info.sh
index 7c7dfbb052..dd2706e1f7 100755
--- a/t/t1900-repo-info.sh
+++ b/t/t1900-repo-info.sh
@@ -184,6 +184,7 @@ test_expect_success 'setup test repository layout for path fields' '
mkdir -p test-repo/sub
'

+test_repo_info_path 'commondir' '../.git'
test_repo_info_path 'gitdir' '../.git'
I was thinking here, maybe you need to take a look at
git-rev-parse's tests and check what are the corner cases.

For example, `git rev-parse --git-common-dir` documentation
says:

    --git-common-dir:
        Show $GIT_COMMON_DIR if defined, else $GIT_DIR

This way, you should take a look on how git-rev-parse tests
test those two cases (GIT_COMMON_DIR and GIT_DIR) and do
something similar here.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help