Thread (1 message) 1 message, 1 author, 2026-03-11

Re: [PATCH v3 2/2] list-objects-filter-options: avoid strbuf_split_str()

From: Junio C Hamano <hidden>
Date: 2026-03-11 18:13:40

Jeff King [off-list ref] writes:
On Wed, Mar 11, 2026 at 05:33:36PM +0000, Deveshi Dwivedi wrote:
quoted
+	while (*p && !result) {
+		const char *end = strchrnul(p, '+');
+
+		strbuf_reset(&sub);
+		strbuf_add(&sub, p, end - p);
+
+		if (sub.len)
+			result = parse_combine_subfilter(filter_options, sub.buf, errbuf);
+
+		if (!*end)
+			break;
+		p = end + 1;
 	}
+	strbuf_release(&sub);
This version of the loop looks good to me.

-Peff
Thanks, both.  Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help