Koji Nakamaru [off-list ref] writes:

Although I don't have much experience with the Watchman backend, the
fixes look correct to me.

One suggestion: it seems we can make the code even cleaner by removing
$retry and its associated logic, as they appear to be no longer
necessary after these changes.

Good point. $retry only existed to prevent the infinite recursion
from the recursive launch_watchman() call, so now that we've
removed that call it's dead code. Cleaned it up in v2.

Thanks for the review,
Paul