Thread (2 messages) 2 messages, 2 authors, 2026-02-22

Re: [PATCH] t2004: use test_path_is_file instead of test -f

From: Usman Akinyemi <hidden>
Date: 2026-02-22 09:45:11

quoted hunk ↗ jump to hunk
                test $(cat ../$s1) = tree1asubdir/path5)
@@ -230,7 +230,7 @@ test_expect_success 'checkout --temp symlink' '
        test_line_count = 1 actual &&
        test $(cut "-d  " -f2 actual) = path6 &&
        p=$(cut "-d     " -f1 actual) &&
-       test -f $p &&
+       test_path_is_file $p &&
        test $(cat $p) = path7
 '

base-commit: 67ad42147a7acc2af6074753ebd03d904476118f
--
gitgitgadget
I reviewed this patch, it looks good to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help