Thread (3 messages) 3 messages, 3 authors, 2026-02-26

Re: [Outreachy PATCH v7 0/3] store repo specific config values in new `struct repo_config_values`

From: Bello Olamide <hidden>
Date: 2026-02-18 11:27:33

On Tue, 17 Feb 2026 at 21:08, Junio C Hamano [off-list ref] wrote:
Olamide Caleb Bello [off-list ref] writes:
quoted
Changes in v7:
==============
- Added the code to reset the initialization of the_repository
  in the fuzz-commit-graph test in Patch 1.
- Changed the call to rep_config_values_init() in
  initialze_repository() by passing it the repo config_values_private_
  struct instead of the accessor function in Patch 1.
- Modified the commit message in Patch 1
- Added extra lines between variable declarations and code
quoted
     +struct repo_config_values *repo_config_values(struct repository *repo)
     +{
    ++        if (repo != the_repository)
    ++                BUG("trying to read config from wrong repository instance");
     +        if(!repo->initialized)
$ git clang-format --diff $(git merge-base master HEAD)

would have pointed out the style issue here.

Will amend while queuing but it would be a bit before I can get to
this patch set for real reviews.

Thanks.
Sorry about missing this style issue and thank you for your reviews and guidance
Do I wait for this before continuing to move other repo specific config values
into the struct since I might need to rebase?

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help