Re: [PATCH v2 2/2] help: cleanup the contruction of keys_uniq

Eric Sunshine [off-list ref] writes:

On Thu, Feb 12, 2026 at 11:30 PM Junio C Hamano [off-list ref] wrote:

quoted

Amisha Chhajed [off-list ref] writes:

quoted

+test_expect_success 'git help --config-for-completion' '
+     file="$GIT_SOURCE_DIR/Documentation/config/add.adoc" &&
+     test_when_finished "git -C \"$GIT_SOURCE_DIR\" checkout -- Documentation/config/add.adoc" &&
+     cat <<-\EOF >>"$file" &&
+     aa*.b::
+     aa.b::
+     EOF
+     git help -c >human &&
+     grep -E \
+          -e "^[^.]+\.[^.]+$" \
+          -e "^[^.]+\.[^.]+\.[^.]+$" human |
+          sed -e "s/\*.*//" -e "s/<.*//" |
+          sort -u >human.munged &&

Dedent "sed" and "sort" to the same level as "grep -E".

Also, don't we usually avoid having both `grep` and `sed` in the same
pipeline like this, considering that `sed` alone should be able to
handle the job itself?

Yes, we often say "do not pipe output of grep or awk to sed".  I did
not want to burden a bit too much on a contributor who is relatively
new to the list.

Thanks.