Re: [PATCH v5 3/4] refs: allow reference location in refstorage config

Jeff King [off-list ref] writes:

On Mon, Feb 09, 2026 at 04:58:20PM +0100, Karthik Nayak wrote:

quoted

+static void parse_reference_uri(const char *value, char **format,
+				char **payload)
+{
+	char *schema_end;
+
+	schema_end = strstr(value, "://");
+	if (!schema_end) {
+		*format = xstrdup(value);
+		*payload = NULL;
+	} else {
+		*format = xstrndup(value, schema_end - value);
+		*payload = xstrdup_or_null(schema_end + 3);
+	}
+}

The schema_end variable should be "const" here. Otherwise new versions
of gcc/glibc will complain that the strstr() implicitly removes the
const from value (and compilation with DEVELOPER=1 fails). More details
in this thread:

  https://lore.kernel.org/git/e6f7e2eddbc9aef1c21f661420a4b8cb9cd8e2c1.1770095829.git.collin.funk1@gmail.com/ (local)

-Peff

Thanks for the hint, my Linux distribution is still on glibc 2.42 and
didn't see the error. Will fix it in my next version.