Thread (1 message) 1 message, 1 author, 2026-02-09

Re: [PATCH 0/4] trace2: add macOS and Windows process ancestry tracing

From: Junio C Hamano <hidden>
Date: 2026-02-09 17:05:33

Derrick Stolee [off-list ref] writes:
quoted
Furthermore, let's refactor the Windows implementation to align with the
Linux and macOS versions - by emitting the ancestry information as a
cmd_ancestry event. We keep the older, custom data_json event type on
Windows for compatibility for consumers of the TRACE2 data that use the
older event.
I appreciate this compatibility approach. I mention in my patch-by-patch
review that we should eventually drop the old mechanism, say in two major
versions.

The code looks good to me, just a question about the testing and some very
minor nitpicks around recursion and strvecs.
Thanks for a prompt review (and thanks for the series author for
writing the patches, of course).

Will mark as "expecting a hopefully minor and final reroll".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help