Re: Re* [RFH] adding test coverage for contrib/ in CI jobs
From: Junio C Hamano <hidden>
Date: 2026-02-05 20:54:21
Junio C Hamano [off-list ref] writes:
Colin Stagner [off-list ref] writes: ...quoted
At least some of the subtree failures on linux-reftable, such as <https://github.com/git/git/actions/runs/21617099884/job/62298228602#step:10:421> are actually due to a bug in ubuntu:rolling's "dirname" implementation.Ahh, rust bites again? Is there /etc/alternatives/dirname like /etc/alternatives/sudo that we used in fddb4842 (ci: fix broken jobs on Ubuntu 25.10 caused by switch to sudo-rs(1), 2025-10-10) to work a breakage around, I have to wonder...
So I tried a custom CI run that has * a temporary patch that demotes ubuntu:rolling to ubuntu:latest in GitHub workflows * your subtree test fix to use the hardcoded 'main' * a similar fix for diff-highlight test <xmqq7bstsemv.fsf@gitster.g> * a change to run "make test" in contrib/* directories <xmqqjywuyhu9.fsf@gitster.g> on top of 'master'. Everything seems to be happy. https://github.com/git/git/actions/runs/21726017981