Thread (1 message) 1 message, 1 author, 2026-02-02

Re: [PATCH 0/5] submodule: add 'reversive' traversal options to foreach

From: Junio C Hamano <hidden>
Date: 2026-02-02 21:25:43

William Hatfield [off-list ref] writes:
Do you have any recommendation regarding names of these flags?
Not really.  To be honest, I didn't even check to make sure what the
behaviour was that your "--reverse" was implementing ;-).
Do you have a preference for: —postorder-traversal or —bottom-up-traversal?
If all three kinds of *order makes sense to the submodule traversal,
then --{pre,in,post}order would make sense.  In other words, does
there exist a good answer to this question: 

    What does "--inorder-traversal" would do and when would it be
    useful, as opposed to --preorder and --postorder?

Otherwise, the distinction between --bottom-up vs --top-down may be
sufficient to explain, and may explain the concept using more
familiar terms to us non-mathematics types.
What about: —include-superpoject or —execute-in-superproject-last?
Depends on what you are trying to tell the command to do with these
options.

The former sounds as if you are saying "we usually do these things
only in submodules and never in superproject. But with this option I
am telling you to do the same in superproject after you are done
doing them in all the submoudles".

On the other hand, the latter sounds more like "do these things in
each and every repository (both submodules and the superproject),
but make sure the repository for superproject is handled after all
others."

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help