Thread (3 messages) 3 messages, 2 authors, 2026-01-26

Re: [PATCH 1/2] u-string-list: add unit tests for string-list methods

From: Junio C Hamano <hidden>
Date: 2026-01-26 19:17:34

Amisha Chhajed [off-list ref] writes:
quoted
quoted
+     for (int i = 0; i < strings_to_insert.nr; i++) {
As strings_to_insert.nr is of type size_t, even though int is plenty
large enough in practice, the compiler will complain.
quoted
+             string_list_insert(&list, strings_to_insert.items[i].string);
+     }
Also, lose the {} around a single statement block.
Done, Thanks for the review.
Heh, that wasn't even a review but a knee-jerk reaction to compiler
warnings.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help