Thread (1 message) 1 message, 1 author, 2026-01-26

Re: [PATCH 0/3] Small fixups for `OBJECT_INFO` flags

From: Junio C Hamano <hidden>
Date: 2026-01-26 16:28:31

Patrick Steinhardt [off-list ref] writes:
Surprisingly though I found out that this breaks tests, which of course
puzzled me. As it turns out though, we were incorrectly using a couple
of these flags for `odb_has_object()`, and the changed definitions had
overlap with the existing meaning of other `HAS_OBJECT_*` flags. There
isn't really any bug here as far as I can see, but this is only really
by chance.
Great findings.
In any case, the first two commits fix calls to `odb_has_object()` that
used invalid flags. The last commit then removes the gaps and converts
the flags to use an enum instead.
Nice.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help