Thread (1 message) 1 message, 1 author, 2026-01-19

Re: [PATCH] sparse-checkout: optimize string_list construction

From: Junio C Hamano <hidden>
Date: 2026-01-19 19:06:24

Jeff King [off-list ref] writes:
On Fri, Jan 16, 2026 at 11:11:16AM -0800, Junio C Hamano wrote:
quoted
quoted
Improve O(n^2) complexity to O(n log n) while building a sorted
'string_list' by constructing it unsorted then sorting it
followed by removing duplicates.
By the way, do we have t/perf/ that substanticates the performance
claim here (in other words, how much improvement are we expecting in
practice)?
IMHO it is not that big a deal to demonstrate the perf improvement in
the test suite.
... a one-off hyperfine output in the commit message would be
enough.
Thanks, I agree with this conclusion; I didn't expect a huge
difference from this change unless N is meaningfully large anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help