Re: [PATCH v2 3/3] last-modified: verify revision argument is a commit-ish

"Kristoffer Haugsbakk" [off-list ref] writes:

On Wed, Jan 14, 2026, at 11:24, Toon Claes wrote:

quoted

Passing a tree OID to git-last-modified(1) would trigger BUG behavior.

    git last-modified HEAD^{tree}
    BUG: builtin/last-modified.c:456: paths remaining beyond boundary
in last-modified

Fix this error by verifying the parsed revision peels to a commit-ish.

Nitpick: “peels to commit-ish” = commit-ish so this is a bit
redundant. Either just “commit-ish” or “peels to commit” would be
enough.

Great eyes ;-)

s/verifying the parsed revision peels to a commit-ish./verifying that the parsed revision is a commit-ish./

quoted

While at it, also fix a memory leak in populate_paths_from_revs().

(Whether or not this is a stale sentence (see Patricks’)) Why not a
separate commit for fixing a memory leak?

quoted

Reported-by: Gusted <redacted>
Signed-off-by: Toon Claes <redacted>
---
[snip]