Thread (10 messages) 10 messages, 3 authors, 2026-01-05

Re: [PATCH v3] t1300: use test helpers instead of test builtins

From: Pushkar Singh <hidden>
Date: 2026-01-04 19:40:18

Hi Abraham,

Thanks for pointing that out.

Understood. I should keep the commit message itself focused on the change,
and describe what was updated between versions under the `---` section.

I will send a v4 with the commit message adjusted accordingly and include a
"Changes in v4" note below the separator.

Thanks for the clarification.
Pushkar

On Sun, Jan 4, 2026 at 9:04 PM Abraham Samuel Adekunle
[off-list ref] wrote:
quoted
This version updates the commit message to avoid calling `test` a shell
primitive, as suggested.
quoted
Signed-off-by: Pushkar Singh <redacted>
---
Hello Pushkar,

I think the right approach to send an updated version after modifying your commit
message is to modify your commit message to INCLUDE the recommendation, not change
the commit message to the recommendation alone.
Then under these three dashes after the 'Signed-off-by:', (---), which is here,
where I am currently replying to you, you state what you changed in the new version
compared to the previous version.

e.g

Changes in v3:
- Modified commit message to ...
- Modified subject to use builtin instead of primitive


Thanks
Abraham.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help