Re: [PATCH] doc: define timestamp in pack protocol grammar
From: Junio C Hamano <hidden>
Date: 2026-01-04 06:28:31
"Heath Dutton🕴️ via GitGitGadget" [off-list ref] writes:
From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?= [off-list ref]
This name is expected to be identical to ...
The grammar for depth-request uses 'timestamp' but never defines it, unlike 'depth' which is properly defined as '1*DIGIT'. Add the missing definition. Signed-off-by: Heath Dutton <redacted>
... what we have here. There is something weird going on after the name before the e-mail on the in-body From: line, though?
quoted hunk
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1 Pull-Request: https://github.com/git/git/pull/2154 Documentation/gitprotocol-pack.adoc | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc index 837b691c89..7ad63322c2 100644 --- a/Documentation/gitprotocol-pack.adoc +++ b/Documentation/gitprotocol-pack.adoc@@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line. additional-want = PKT-LINE("want" SP obj-id) depth = 1*DIGIT + timestamp = 1*DIGIT
OK. It was added at 569e554b (upload-pack: add deepen-since to cut shallow repos based on time, 2016-06-12) by Duy for deepen-since which is parsed using parse_timestamp() that is a fancier name for strtoumax(), so 1*DIGIT sounds fine. Thanks.