Thread (2 messages) 2 messages, 2 authors, 2025-12-25

Re: [PATCH] refs: dereference the value of the required pointer

From: Karthik Nayak <hidden>
Date: 2025-12-25 21:23:23

Junio C Hamano [off-list ref] writes:
"AZero13 via GitGitGadget" [off-list ref] writes:
quoted
From: Greg Funni <redacted>

Currently, this always prints yes because required is non-null.

This is the wrong behavior. The boolean must be
dereferenced.
The line is blamed to f6c5ca38 (refs: add a `optimize_required`
field to `struct ref_storage_be`, 2025-11-08); the author CC'ed for
an Ack.

Thanks.
My responses are a bit slow due to being on holiday.

The patch looks good to me, the fix makes sense. Thanks both!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help