[PATCH v2] repository: remove duplicate free of cache->squash_msg
From: AZero13 via GitGitGadget <hidden>
Date: 2025-12-18 15:49:14
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Greg Funni <redacted>
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
Signed-off-by: Greg Funni <redacted>
---
repository: remove duplicate free of cache->squash_msg
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
Signed-off-by: Greg Funni gfunni234@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2132%2FAZero13%2Ftwice-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2132/AZero13/twice-v2
Pull-Request: https://github.com/git/git/pull/2132
Range-diff vs v1:
1: 35d0606190 ! 1: ac2abd592d repository: cache->squash_msg is freed twice
@@ Metadata
Author: Greg Funni [off-list ref]
## Commit message ##
- repository: cache->squash_msg is freed twice
+ repository: remove duplicate free of cache->squash_msg
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
repository.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/repository.c b/repository.c
index 863f24411b..c7e75215ac 100644
--- a/repository.c
+++ b/repository.c@@ -349,7 +349,6 @@ out: static void repo_clear_path_cache(struct repo_path_cache *cache) { - FREE_AND_NULL(cache->squash_msg); FREE_AND_NULL(cache->squash_msg); FREE_AND_NULL(cache->merge_msg); FREE_AND_NULL(cache->merge_rr);
base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda -- gitgitgadget