Re: [PATCH v8 2/3] fetch: fix non-conflicting tags not being committed
From: Patrick Steinhardt <hidden>
Date: 2025-12-01 12:58:19
On Fri, Nov 21, 2025 at 12:13:46PM +0100, Karthik Nayak wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index b7059cccaa..4b113d7c27 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh@@ -1577,6 +1578,67 @@ test_expect_success REFFILES 'D/F conflict on case sensitive filesystem with loc
[snip]
+test_expect_success "backfill tags when providing a refspec" ' + test_when_finished rm -rf source target && + + git init source && + git -C source commit --allow-empty --message common && + git clone file://"$(pwd)"/source target && + ( + cd source && + test_commit history && + test_commit fetch-me + ) && + + # The "history" tag is backfilled eventhough we requested
Tiny nit, not worth a reroll: s/eventhough/even though/. Other than that this patch looks good to me. Patrick