Re: [PATCH v6 0/4] rebase: support --trailer
From: Li Chen <hidden>
Date: 2025-11-17 03:38:19
Hi Phillip, Sorry for my late reply. ---- On Wed, 12 Nov 2025 22:50:27 +0800 Phillip Wood [off-list ref] wrote --- > Hi Li > > On 05/11/2025 14:29, Li Chen wrote: > > From: Li Chen [off-list ref] > > > > This series routes all trailer insertion through an in-process path, removing > > the fork/exec to builtin/interpret-trailers and tempfile juggling. The first > > three commits centralize logic to reduce overhead and simplify error handling. > > The final commit adds git rebase --trailer, currently supported with the merge > > backend only (rejecting apply-only scenarios and validating input early). > > I've left quite a few comments but overall this is looking much better > now, it needs a bit of cleaning up but I didn't spot any major issues. > > Thanks for working on it Thanks for your kind reviews! I will address them in the next version. Regards, Li