On Wed, Oct 29, 2025 at 5:12 PM Junio C Hamano [off-list ref] wrote:

Christian Couder [off-list ref] writes:

quoted

On Tue, Oct 28, 2025 at 2:43 PM Junio C Hamano [off-list ref] wrote:

quoted

quoted

Makes sense.  Should we also downcase some Unknown and Unexpected?

I am fine with doing it as part of this series, but I wonder if it
should be part of this patch or in a separate patch.

If it's in a separate patch, each patch might be easier to review
independently, but a number of lines will be changed several times in
this series. So not sure what's the best practice.

Rephrasing the messages may need more careful thinking while
reviewing, but if you limit your changes to only downcasing the
first letter, I would think it would fall in the same bucket as
"While at it, improve code indentation".

I did it in the same patches in the v2 I just sent, but an issue I
faced was that some tests in "t9300-fast-import.sh" check for some
error messages in a case sensitive way, so I had to make changes in
those tests.