Thread (50 messages) 50 messages, 2 authors, 2025-11-03

Re: [PATCH 05/13] object-file: introduce `struct odb_loose_source`

From: Karthik Nayak <hidden>
Date: 2025-10-30 10:48:00

Patrick Steinhardt [off-list ref] writes:
Currently, all state that relates to loose objects is held directly by
the `struct odb_source`. Introduce a new `struct odb_loose_source` to
hold the state instead so that it is entirely self-contained.
I wonder if the naming should instead be `struct obd_source_loose` that
way other backends (if added) would be something like:

    struct obd_source_loose
    struct obd_source_postgres
    struct obd_source_mongo

This is easier to read and also for autocompletion it leads nicely into
the 'obd_source_...' namespace.

The patch looks good.

[snip]

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help