Re: [Outreachy PATCH v5 1/2] gpg-interface: do not use misdesigned strbuf_split*()

On Wed, 22 Oct 2025 at 14:56, Christian Couder
[off-list ref] wrote:

On Wed, Oct 22, 2025 at 2:40 PM Olamide Caleb Bello [off-list ref] wrote:

quoted

In get_ssh_finger_print(), the output of the `ssh-keygen` command is
put into `fingerprint_stdout` strbuf.
The string in `fingerprint_stdout` is then split into up to 3 strbufs

Nit: it's not clear if the first sentence of this commit message is
part of the same paragraph as the second sentence or not. If you
reroll this patch, I would suggest making it clearly part of the same
paragraph like this:

"In get_ssh_finger_print(), the output of the `ssh-keygen` command is
put into `fingerprint_stdout` strbuf. The string in `fingerprint_stdout` is
then split into up to 3 strbufs using strbuf_split_max(). However..."

Otherwise this patch looks fine to me.

Thanks.

Okay thank you very much

Bello