Thread (33 messages) 33 messages, 2 authors, 2025-11-04
STALE242d
Revisions (2)
  1. v4 [diff vs current]
  2. v5 current

[PATCH v5 12/29] rebase: drop redundant strbuf_release call

From: Li Chen <hidden>
Date: 2025-10-22 05:42:21
Subsystem: the rest · Maintainer: Linus Torvalds

Removed the redundant strbuf_release() call in
read_basic_state() so the buffer is released once
even if strbuf_read_file() fails.

Signed-off-by: Li Chen <redacted>
---
 builtin/rebase.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 89ecb84a31..a950005dfc 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -524,7 +524,6 @@ static int read_basic_state(struct rebase_options *opts)
 
 			p = nl + 1;
 		}
-		strbuf_release(&buf);
 	}
 	strbuf_release(&buf);
 
-- 
2.51.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help