Thread (158 messages) 158 messages, 3 authors, 2025-10-16

Re: [PATCH 41/49] builtin/repack.c: use `write_pack_opts` within `write_cruft_pack()`

From: Patrick Steinhardt <hidden>
Date: 2025-10-10 12:28:45

On Sun, Sep 28, 2025 at 06:09:57PM -0400, Taylor Blau wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin/repack.c b/builtin/repack.c
index 6df7c88085..501359c580 100644
--- a/builtin/repack.c
+++ b/builtin/repack.c
@@ -221,9 +221,7 @@ static void combine_small_cruft_packs(FILE *in, size_t combine_cruft_below_size,
 	strbuf_release(&buf);
 }
 
-static int write_cruft_pack(const struct pack_objects_args *args,
-			    const char *destination,
-			    const char *pack_prefix,
+static int write_cruft_pack(struct write_pack_opts *opts,
 			    const char *cruft_expiration,
 			    unsigned long combine_cruft_below_size,
 			    struct string_list *names,
Same question here regarding the constness. Subsequent patches also
surface this question.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help