Thread (6 messages) 6 messages, 4 authors, 2025-10-02

Re: How mantainers check Git diffs and patches?

From: Konstantin Ryabitsev <hidden>
Date: 2025-10-01 13:37:36

On Wed, Oct 01, 2025 at 12:30:43AM -0300, Henrique Soares wrote:
This is a simple question I have related to the PR diff review process.

How Git maintainers use to check diffs and review the code? I mean,
sometimes I see that there are some large PATCHES that is hard or
probably impossible to review only using e-mail client.

Do you use some syntax highlight in client e-mail; any pipeline that
automatically download e-mails and apply to a local branch; or for each
PR you save the e-mail file then "git apply" to review / test the diff?
There are tools that make it easy to apply a patch series to your local tree.
For example, here's a random patch series from the list:

    https://lore.kernel.org/git/20250919010911.649831-1-sandals@crustytoothpaste.net (local)

This will apply it on top of the current HEAD:

    b4 shazam https://lore.kernel.org/git/20250919010911.649831-1-sandals@crustytoothpaste.net (local)

This will fetch it into FETCH_HEAD, making it behave pretty identical to a
pull request:

    b4 shazam -H https://lore.kernel.org/git/20250919010911.649831-1-sandals@crustytoothpaste.net (local)

From here, you can check out FETCH_HEAD to run tests or do a commit-by-commit
review.

Hope this helps,
-K
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help