On Tue, Sep 23, 2025 at 3:45 AM Patrick Steinhardt [off-list ref] wrote:
Your patch series has 2 critical problems:
  * meson doesn't check for "is windows and using msvc" -> <crate>.lib
else lib<crate>.a
  * Using the name "git" for the crate is problematic because both
Make and Meson already produce libgit.a which is different from the
libgit.a that cargo is producing. Change the name in Cargo.toml from
"git" to "gitcore".

I created some temporary patches on top of this patch series that
always forces Rust and then pushed it to GitHub. The only target that
failed was windows building with meson + msvc, everything else
including the 32 bit linux target passed.

I have some nitpicks about varint, but they're not worth mentioning
here. Fix those 2 points and you'll have my seal of approval for this
patch series.