Thread (14 messages) 14 messages, 3 authors, 2025-09-03

Re: [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand

From: Meet Soni <hidden>
Date: 2025-08-31 06:20:44

Thanks for the review, and apologies for missing your email earlier, I just saw
your comments today.

On Tue, 26 Aug 2025 at 20:48, shejialuo [off-list ref] wrote:
On Tue, Aug 26, 2025 at 01:06:45PM +0530, Meet Soni wrote:
quoted
diff --git a/t/t1463-refs-optimize.sh b/t/t1463-refs-optimize.sh
new file mode 100755
index 0000000000..c11c905d79
--- /dev/null
+++ b/t/t1463-refs-optimize.sh
@@ -0,0 +1,17 @@
+#!/bin/sh
+
+test_description='git refs optimize should not change the branch semantic
+
+This test runs git refs optimize and git show-ref and checks that the branch
+semantic is still the same.
+'
When reading the description, I am wondering how this test runs `git
refs optimize` and `git show-ref` to achieve the goal. Should we simply
just say we use "pack-refs-tests.sh" to ensure the compatibility with
the `git pack-refs`?
You're right that the current description is too tied to implementation details
(git show-ref). The intent of this test is to ensure that git refs optimize
does not change branch semantics, similar to the existing pack-refs tests.

I'll update the description to focus on the behavior being verified, not the
specific commands used.
quoted
+
+GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
+export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+GIT_TEST_DEFAULT_REF_FORMAT=files
+export GIT_TEST_DEFAULT_REF_FORMAT
+
+. ./test-lib.sh
+
+pack_refs='refs optimize'
+. "$TEST_DIRECTORY"/pack-refs-tests.sh
--
2.34.1
Thanks,
Jialuo
Thanks,
Meet
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help