Thread (2 messages) 2 messages, 2 authors, 2025-08-29

Re: [PATCH 5/5] midx-write: reenable signed comparison errors

From: Taylor Blau <hidden>
Date: 2025-08-29 01:35:59

On Thu, Aug 28, 2025 at 02:01:42PM -0700, Junio C Hamano wrote:
"Derrick Stolee via GitGitGadget" [off-list ref] writes:
quoted
The strategy here involves defining the variable within the for loop
syntax to make sure we use the appropriate bitness for the loop
sentinel. This matters in at least one method where the variable was
compared to uint32_t in some loops and size_t in others.
Sounds like a fine way to avoid accidentally breaking these loops.
Yup, all looks good to me.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help