Re: [PATCH v3 0/4] bulk-checkin: remove global transaction state
From: Junio C Hamano <hidden>
Date: 2025-08-25 20:25:21
Justin Tobler [off-list ref] writes:
Changes since V2: - `index_blob_bulk_checkin()` is combined with `deflate_blob_bulk_checkin()` in patch 3 instead of 4. - Continue to use `repo_get_object_directory()` instead of open coding. Changes since V1: - `index_blob_bulk_checkin()` now assumes that the caller always provides a setup `struct odb_transaction`. Callers are adjusted to ensure this. - Functions in bulk-checkin.c now consistently access the repository through the provided `odb_transaction`. Thanks, -Justin Justin Tobler (4): bulk-checkin: introduce object database transaction structure bulk-checkin: remove global transaction state bulk-checkin: require transaction for index_blob_bulk_checkin() bulk-checkin: use repository variable from transaction builtin/add.c | 5 +- builtin/unpack-objects.c | 5 +- builtin/update-index.c | 7 +- bulk-checkin.c | 152 +++++++++++++++++++++------------------ bulk-checkin.h | 25 ++++--- cache-tree.c | 5 +- object-file.c | 30 +++++--- odb.h | 8 +++ read-cache.c | 5 +- 9 files changed, 141 insertions(+), 101 deletions(-)
Looking good. Will queue. Thanks.