Thread (1 message) 1 message, 1 author, 2025-08-07

Re: [GSoC PATCH v8 5/5] repo: add the --format flag

From: Junio C Hamano <hidden>
Date: 2025-08-07 15:45:00

Patrick Steinhardt [off-list ref] writes:
quoted
+		default:
+			BUG("%d: not a valid output format", format);
Nit: we typically say it the other way round.

	BUG("not a valid output format: %d", format);
It is in the coding guidelines

 - Say what the error is first ("cannot open '%s'", not "%s: cannot open").

but sometimes we forget.  Thanks for good eyes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help