Thread (178 messages) 178 messages, 10 authors, 2025-08-16

Re: [GSoC PATCH v7 3/5] repo: add the field layout.bare

From: Eric Sunshine <hidden>
Date: 2025-08-03 23:06:35

On Sun, Aug 3, 2025 at 6:54 PM Lucas Seiki Oshiro
[off-list ref] wrote:
quoted
The quote placement used in these calls to `test_repo_info` is quite
unusual and more than a little confusing. I'm guessing you did it this
way to avoid having to use a backslash to continue the line or did it
to mimic how `test_expect/fail` is called
Yeah, that's true :-). I'll change it. However, in the next patch, where
I add `repository.shallow`, I need a more complex script for creating
a shallow repository which needs several lines. In this case, do you
think it would it be better to use the backslash before the line break
or would it be like it currently is?
If you take the suggestion I made in my review[*] of that subsequent
patch (specifically, create a separate "setup"-style test), then I'm
pretty sure you won't need to use the complex script for the function
argument; it should collapse to a single line as shown in [*].

[*]: https://lore.kernel.org/git/CAPig+cTtJHn3NxrXF-AU_0cRzccDOo+j8JTAq1Jyqm4BzXBpSw@mail.gmail.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help