Re: [PATCH v2 2/3] config: warn on core.commentString=auto

On Thu, Jul 31, 2025 at 04:21:54PM +0100, Phillip Wood wrote:

From: Phillip Wood <redacted>

As support for this setting was deprecated in the last commit print a
warning (or die when WITH_BREAKING_CHANGES is enabled) if it is set.
When printing a warning avoid bombarding the user by only printing it

when running commands commands that run "git commit" and only only

something is very wrong with this line.

once per command. Some scaffolding is added to repo_read_config()
to allow it to detect deprecated config settings and warn about
them. As both "core.commentChar" and "core.commentString" set the
comment character we record which one of them is used and tailor the
warning message appropriately.