Thread (16 messages) 16 messages, 2 authors, 2025-07-29
STALE355d
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 0/5] ref-filter: small cleanups and fixes

From: Karthik Nayak <hidden>
Date: 2025-07-28 20:20:53

This series contains a few of the small fixes and comments which I've
gathered from reviews of my earlier series [1] to add the
'--start-after' flag to 'git-for-each-ref(1)'.

Individually each patch doesn't hold too much weight on its own, but
together these small improvements add up. That said, if these patches
are too small for the noise generated, we could simply drop it or
combine some commits together.

This is based on top of 3f2a94875d (The twelfth batch, 2025-07-21) with
'kn/for-each-ref-skip' merged in.

[1]: https://lore.kernel.org/r/20250701-306-git-for-each-ref-pagination-v1-0-4f0ae7c0688f@gmail.com (local)

Signed-off-by: Karthik Nayak <redacted>
---
Changes in v2:
- In Patch 2/5, fix a whitespace issue and convert 'git-for-each-ref(1)'
  documentation to use the new synopsis block.
- Link to v1: https://lore.kernel.org/r/20250724-kn-small-cleanups-v1-0-0c70f591de3e@gmail.com (local)

---
 Documentation/git-for-each-ref.adoc | 13 +++++++------
 builtin/for-each-ref.c              |  2 +-
 ref-filter.c                        |  5 +++--
 refs/ref-cache.c                    |  5 +++--
 t/t6302-for-each-ref-filter.sh      | 19 +++++++++++++++++++
 5 files changed, 33 insertions(+), 11 deletions(-)

Karthik Nayak (5):
      ref-cache: use 'size_t' instead of int for length
      for-each-ref: fix documentation argument ordering
      for-each-ref: reword the documentation for '--start-after'
      t6302: add test combining '--start-after' with '--exclude'
      ref-filter: use REF_ITERATOR_SEEK_SET_PREFIX instead of '1'

Range-diff versus v1:

1:  449473efe6 = 1:  cb34545b3a ref-cache: use 'size_t' instead of int for length
2:  b5aec572bc < -:  ---------- for-each-ref: fix documentation argument ordering
-:  ---------- > 2:  3fab0eda31 for-each-ref: fix documentation argument ordering
3:  005a35a4b3 = 3:  49e5aa69f2 for-each-ref: reword the documentation for '--start-after'
4:  162f5de259 = 4:  93babd3e71 t6302: add test combining '--start-after' with '--exclude'
5:  3eb8591385 = 5:  ce90149919 ref-filter: use REF_ITERATOR_SEEK_SET_PREFIX instead of '1'


base-commit: 15fcbd8f16a2c119a5319b0657e52fe0f387df46
change-id: 20250721-kn-small-cleanups-a01fe5d2756d

Thanks
- Karthik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help