Thread (44 messages) 44 messages, 5 authors, 2025-07-17

Re: [PATCH v4 3/4] refs: selectively set prefix in the seek functions

From: Karthik Nayak <hidden>
Date: 2025-07-15 08:19:58

Christian Couder [off-list ref] writes:
On Fri, Jul 11, 2025 at 6:20 PM Karthik Nayak [off-list ref] wrote:
quoted
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 03f5df04d5..90de7837f8 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -353,11 +353,12 @@ void base_ref_iterator_init(struct ref_iterator *iter,
 typedef int ref_iterator_advance_fn(struct ref_iterator *ref_iterator);

 /*
- * Seek the iterator to the first reference matching the given prefix. Should
- * behave the same as if a new iterator was created with the same prefix.
+ * Seek the iterator to the first matching reference. If set_prefix is set,
s/If set_prefix is set/If the REF_ITERATOR_SEEK_SET_PREFIX flag is set/
Will change, thanks.
quoted
+ * it would behave the same as if a new iterator was created with the same
+ * prefix.
Maybe: s/with the same prefix/at the same reference/
Changed it to

  If the REF_ITERATOR_SEEK_SET_PREFIX flag is set, it would behave the
  same as if a new iterator was created with the provided refname as prefix.
quoted
  */
 typedef int ref_iterator_seek_fn(struct ref_iterator *ref_iterator,
-                                const char *prefix);
+                                const char *refname, unsigned int flags);

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help