Re: [GSOC PATCH v5 0/3] environment: remove sparse-checkout related global variables

Hi Junio,

On Wed, Jul 9, 2025 at 5:48 AM Junio C Hamano [off-list ref] wrote:

Ayush Chandekar [off-list ref] writes:

quoted

This patch series aims to remove global variables related to
sparse-checkout from the global scope and to remove the definition
'#define USE_THE_REPOSITORY_VARIABLE' from a few files.

For this topic, it seems that the ball is in the author's court
after a few review comments.  What's the status of it?

If it is back-burnered for now, then we may eject the topic out of
'seen' to make room for a new topic that touches the same area with
overlapping changes.

Thanks.

Apologies for not keeping you updated. I had actually drafted a
response explaining that in 1/3, I only added two new calls to
`prepare_repo_settings()`. Some other calls were made in cmd_foo()
functions, and a few others were rearranged and removed as well. (I
should've made it clearer in the commit message). In fact, the commit
message mistaknely suggests that one extra call was added which wasn't
the case. For 2/3, only one new call was added. As for 3/3, I can move
the setting into the repo_settings struct, since
`prepare_repo_settings()` is already being called before the variable
is accessed.

At the time, I felt my draft wasn't convincinv enough, and then got
caught up with responses on other patch series and also was working on
another one.

You can eject this topic if you think another one is more important or
if this one still needs work.

Again, Sorry for not updating earlied, will do better next time.

Thanks,
Ayush