Thread (1 message) 1 message, 1 author, 2025-07-08

Re: [PATCH v5] fast-(import|export): improve on commit signature output format

From: Junio C Hamano <hidden>
Date: 2025-07-08 21:58:30

Christian Couder [off-list ref] writes:
A recent commit, d9cb0e6ff8 (fast-export, fast-import: add support for
signed-commits, 2025-03-10), added support for signed commits to
fast-export and fast-import.
...
It could be even better to be able to import more than one signature
on the SHA-1 object and on the SHA-256 object, but other parts of
Git don't handle that well for now, so this is left for future
improvements.

Helped-by: brian m. carlson [off-list ref]
Helped-by: Elijah Newren [off-list ref]
Signed-off-by: Christian Couder <redacted>
---

This v5 is similar in spirit to v4, especially the format of the
"gpgsig ..." command didn't change, but there are a number of
improvements:

  - All the signatures are now exported. On the import side, still at
    most one signature for SHA-1 and one for SHA-256 are imported (and
    a warning is still emitted for additional signatures) though.

  - The code makes sure each signature ends with a LF character. While
    this is not mandatory, it is encouraged and makes the output more
    human readable and 'grep'able.

  - A test with both a SHA-1 and a SHA-256 signature on the same
    commit has been added.

  - Some tests check that either "sha1" or "sha256" is in the "gpgsig
    ..."  command instead of matching "sha(1|256)".

  - The format of the "gpgsig ..." command is better explained both in
    the commit message and in the fast-import documentation.

  - There are some typo fixes, lines wrapped, and a few other such
    small changes.
Thanks.  Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help