Re: [PATCH v2] ssh signing: don't detach the filename strbuf from key_file tempfile
From: brian m. carlson <hidden>
Date: 2025-07-06 21:21:38
Attachments
- signature.asc [application/pgp-signature] 262 bytes
From: brian m. carlson <hidden>
Date: 2025-07-06 21:21:38
On 2025-07-06 at 17:34:49, redoste wrote:
Detaching the filename string from the tempfile structure used to cause delete_tempfile() to fail and the temporary file was not cleaned up. While it's possible to get rid of the allocation and copy from xstrdup(), it keeps the code symetric with the other branch since interpolate_path() also allocates and ssh_signing_key_file is freed in both cases. Helped-by: brian m. carlson [off-list ref] Signed-off-by: redoste <redacted>
Yup, this looks good to me. Thanks so much for the patch; I always appreciate keeping the temporary directory tidy. -- brian m. carlson (they/them) Toronto, Ontario, CA