Thread (26 messages) 26 messages, 4 authors, 2025-07-02

Re: [PATCH v2 3/3] meson: add rule to run 'git clang-format'

From: Patrick Steinhardt <hidden>
Date: 2025-07-02 02:54:56

On Tue, Jul 01, 2025 at 11:12:16AM -0400, Karthik Nayak wrote:
Toon Claes [off-list ref] writes:
quoted
Karthik Nayak [off-list ref] writes:
quoted
diff --git a/meson.build b/meson.build
index 7fea4a34d6..20ce0525a1 100644
--- a/meson.build
+++ b/meson.build
@@ -2144,6 +2144,18 @@ if headers_to_check.length() != 0 and compiler.get_argument_syntax() == 'gcc'
   alias_target('check-headers', hdr_check)
 endif

+git_clang_format = find_program('git-clang-format', required: false)
I think we should include `native: true` as well.
Does it really matter here? I must admit I don't understand the
repercussions here.
It doesn't really, as `native: true` is the default. But we explicitly
say whether we want native or non-native binaries for all the other
calls to `find_program()` to make it more obvious, so I think it would
be a sensible addition here.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help