On Mon, Jun 9, 2025 at 5:13 PM Kristoffer Haugsbakk
[off-list ref] wrote:

On Tue, Jun 3, 2025, at 22:37, D. Ben Knoble wrote:

quoted

quoted

In this case I am not all that sympathetic to the idea of the patch.
The consistently indented lines makes it more clear from which line
to which line came from a commit log message; running stripspace
would break them into paragraph pieces.  These editors that complain
probaly can be fixed?

My editor doesn't complain, but it does highlight trailing whitespace
at my behest, and it tends to be an eyesore (on purpose: that way I
clean it up). Perhaps Kistoffer is coming from a similar place?

Yes exactly.  Ain’t nothing more to it than that.  :)

quoted

quoted

Alternatively, if it bothers users of certain editing environments
too much, perhaps the indent code in the output phase of "git show"
should lose the indents for empty lines uniformly, shoudln't it?  It
probably should be a fairly isolated change, like the way how the
expand_tabs_in_log bit is handled in pretty.c; give another bit and
teach pp_handle_indent to return when that bit is set and the
payload it was asked to show with indentation is empty, or something
like that.

I think this suggestion would also help folks who "git commit -v,"
which IIRC is also indented in the template.

In my testing though it doesn’t introduce trailing whitespace.

Really? When committing a recent patch (editor template attached) with
-v (for testing this), I saw trailing whitespace on the blank line
under the added feed.

--
Kristoffer Haugsbakk

-- 
D. Ben Knoble