Thread (3 messages) 3 messages, 2 authors, 2025-06-03

Re: [PATCH] config.mak.dev: enable -Wunreachable-code

From: Junio C Hamano <hidden>
Date: 2025-06-03 22:07:39

Mike Hommey [off-list ref] writes:
There is a similar problem with this code in refs/files-backend.c:

			if (!create_ref_symlink(lock, update->new_target))
				continue;

Where create_ref_symlink is defined as such:

#ifdef NO_SYMLINK_HEAD
#define create_ref_symlink(a, b) (-1)
#else
static int create_ref_symlink(struct ref_lock *lock, const char *target)
{
...
#endif

And NO_SYMLINK_HEAD is defined on Windows.
Would the NOT_CONSTANT() trick we ended up using for the original
"sigfillset" thing solve your issue as well?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help