Re: [PATCH 2/3] t5516: use double quotes for tests with variables
From: Eric Sunshine <hidden>
Date: 2025-06-02 16:59:50
On Mon, Jun 2, 2025 at 5:58 AM Karthik Nayak [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Since expressions don't expand within single quotes, change test descriptions containing variables to use double quotes. Signed-off-by: Karthik Nayak <redacted> ---diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh@@ -1421,7 +1421,7 @@ test_expect_success 'peeled advertisements are not considered ref tips' ' -test_expect_success 'pushing a specific ref applies remote.$name.push as refmap' ' +test_expect_success "pushing a specific ref applies remote.$name.push as refmap" '
If I'm understanding correctly, I think this and the other changes in this patch are incorrect. There is no `name` variable in this script. Rather, these "$name" instances are merely illustrative, acting as placeholders for the person reading the test title.