Thread (3 messages) 3 messages, 3 authors, 2025-05-30

Re: [PATCH v4 1/2] pack-bitmap: fix memory leak if load_bitmap() failed

From: lidongyan <hidden>
Date: 2025-05-30 03:51:14

Got it, I will add my sign-off.
2025年5月29日 23:33,Junio C Hamano [off-list ref] 写道:

"Taylor Blau via GitGitGadget" [off-list ref] writes:
quoted
From: Taylor Blau <redacted>

After going through the "failed" label, load_bitmap() will return -1,
and its caller (either prepare_bitmap_walk() or prepare_bitmap_git())
will then call free_bitmap_index().
...
The solution is to remove the error handling code in load_bitmap(), because
its caller will always call free_bitmap_index() in case of an error.

Signed-off-by: Taylor Blau <redacted>
---
As this is Lidong relaying [ref] that Taylor
sent to the list, shouldn't Lidong's sign-off be after Taylor's?
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help