Re: [PATCH v3 3/5] meson: correct path to system config/attribute files
From: Patrick Steinhardt <hidden>
Date: 2025-05-19 07:32:39
On Fri, May 16, 2025 at 07:48:41PM +0100, Ramsay Jones wrote:
quoted hunk ↗ jump to hunk
diff --git a/meson_options.txt b/meson_options.txt index 8547c0eb47..7a4b896f7e 100644 --- a/meson_options.txt +++ b/meson_options.txt@@ -3,10 +3,10 @@ option('default_pager', type: 'string', value: 'less', description: 'Fall-back pager.') option('default_editor', type: 'string', value: 'vi', description: 'Fall-back editor.') -option('gitconfig', type: 'string', value: '/etc/gitconfig', - description: 'Path to the global git configuration file.') -option('gitattributes', type: 'string', value: '/etc/gitattributes', - description: 'Path to the global git attributes file.') +option('gitconfig', type: 'string', # default 'etc/gitconfig' + description: 'Path to the global git configuration file. (default: etc/gitconfig)') +option('gitattributes', type: 'string', # default 'etc/gitattributes' + description: 'Path to the global git attributes file. (default: etc/gitattributes)')
Sorry to be nitpicky, but the default information is duplicated. We now have it once as comment and once as description. Other than that this version looks great to me, thanks! Patrick