Thread (27 messages) 27 messages, 2 authors, 2025-05-26

Re: [PATCH v2 09/10] t/unit-tests: convert reftable stack test to use clar

From: Patrick Steinhardt <hidden>
Date: 2025-05-05 09:52:17

On Mon, May 05, 2025 at 10:11:18AM +0100, Seyi Chamber wrote:
On Fri, 2 May 2025 at 10:57, Patrick Steinhardt [off-list ref] wrote:
quoted
On Tue, Apr 29, 2025 at 06:53:01PM +0100, Seyi Kuforiji wrote:
quoted
diff --git a/t/meson.build b/t/meson.build
index 756cb2a2dd..8fa00fc9ef 100644
--- a/t/meson.build
+++ b/t/meson.build
@@ -1102,7 +1102,6 @@ integration_tests = [
 # sufficient to catch missing test suites in our CI though.
 foreach glob, tests : {
   't[0-9][0-9][0-9][0-9]-*.sh': integration_tests,
-  'unit-tests/t-*.c': unit_test_programs,
   'unit-tests/u-*.c': clar_test_suites,
 }
   actual_tests = run_command(shell, '-c', 'ls ' + glob,
Okay. Ideally this would be moved into the next commit where we remove
the infrastructure for our old-style unit tests, but we can't because
the glob matches nothing anymore and thus causes an error.

Also, we have a "check-meson" target in "t/Makefile". Don't we have to
remove unit tests from there, too?

Patrick
You are referring to this, yes?
`@# awk acts up when trying to match single quotes, so we use \047 instead.
    @mkdir -p mesontmp && \
    printf "%s\n" \
        "integration_tests t[0-9][0-9][0-9][0-9]-*.sh" \
        "unit_test_programs unit-tests/t-*.c" \
        "clar_test_suites unit-tests/u-*.c" | \
    while read -r variable pattern; do \`

I've hardly taken a look at the `t/Makefile`, given my very little
interaction with the file throughout the test conversions.
Yes, that's the part I was referring to.

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help