Re: [PATCH v2 00/13] object-store: a handful of cleanups
From: Karthik Nayak <hidden>
Date: 2025-04-28 19:49:31
Attachments
- signature.asc [application/pgp-signature] 690 bytes
From: Karthik Nayak <hidden>
Date: 2025-04-28 19:49:31
Patrick Steinhardt [off-list ref] writes:
Hi,
this patch series contains a handful of cleanups to the object store
subsystem:
- A couple of definitions are moved out of "object-store.h" as they
belong to other subsystems.
- Some functions are dropped and/or renamed.
- The biggest part is the removal of `repo_has_object_file()`. This
function and its `_with_flags()` variant are marked as deprecated,
with the replacement being `has_object()`. The benefit of that
function is that it doesn't reload packfiles and doesn't fetch
promisor objects by default so that it becomes more explicit when
one really wants to do so.
These cleanups are in preparation for getting rid of `the_repository` in
"object-store.c".
The patch series is built on top of 4bbb303af69 (The seventh batch,
2025-04-17) with ps/object-file-cleanup at 68cd492a3e6 (object-store:
merge "object-store-ll.h" and "object-store.h", 2025-04-15) merged into
it.
Changes in v2:
- A handful of improvements for commit messages.
- Link to v1: https://lore.kernel.org/r/20250423-pks-object-store-cleanups-v1-0-81f8411a5d08@pks.im (local)
Thanks!
Patrick[snip] The range-diff looked good to me. Thanks!