Thread (4 messages) 4 messages, 1 author, 2025-04-28

[PATCH 2/3] gitk: do not set fg/bg color scheme for themed Tk

flat view
DORMANTno replies

From: Christoph Sommer via GitGitGadget <hidden>
Date: 2025-04-28 15:56:18
Subsystem: the rest · Maintainer: Linus Torvalds

From: Christoph Sommer <redacted>

Ignore the uicolor preference not just for win32, but also whenever
themed Tk is used. On themed Tk it was frequently only changing the
background of only a few select widgets rather than everything -
and the default uicolor was frequently not the background color that
themed Tk used for its widgets, resulting in a messy looking UI
(mostly light gray, with random widgets surrounded by darker gray borders)

Signed-off-by: Christoph Sommer <redacted>
---
 gitk-git/gitk | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 8cb17f39d41..da7507af360 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11991,6 +11991,12 @@ proc setselbg {c} {
 # radiobuttons look bad.  This chooses white for selectColor if the
 # background color is light, or black if it is dark.
 proc setui {c} {
+    global use_ttk
+
+    if {$use_ttk} {
+        return
+    }
+
     if {[tk windowingsystem] eq "win32"} { return }
     set bg [winfo rgb . $c]
     set selc black
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help