Thread (1 message) 1 message, 1 author, 2025-03-18

Re: [PATCH v2 2/3] run-command: use errno to check for sigfillset() error

From: Junio C Hamano <hidden>
Date: 2025-03-18 00:36:14

Junio C Hamano [off-list ref] writes:
Taylor Blau [off-list ref] writes:
quoted
On Fri, Mar 14, 2025 at 02:09:08PM -0700, Junio C Hamano wrote:
quoted
From: Jeff King <redacted>

Since enabling -Wunreachable-code, builds with clang on macOS now fail,
complaining that the die_errno() call in:

  if (sigfillset(&all))
	die_errno("sigfillset");
Hmm. Would it have made sense to swap the order of this and the first
patch so we don't have a DEVELOPER=1 breakage (for macOS with Clang) in
history?

I think it's too late now since this topic is already on 'next', but it
occurred to me idly while reading this patch.
I thought db1d1f5d (config.mak.dev: enable -Wunreachable-code,
2025-03-14) aka jk/use-wunreachable-code-for-devs~2 is still out of
'next'?
Ah, I did revert an earlier one-commit topic out of 'next'.  Perhaps
I didn't tell What's cooking about it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help