Re: [PATCH v2 0/3] Add a static analysis job to prevent assertions with side effects
From: Taylor Blau <hidden>
Date: 2025-03-17 22:34:13
On Sun, Mar 16, 2025 at 06:41:59AM +0000, Elijah Newren via GitGitGadget wrote:
Elijah Newren (3): git-compat-util: introduce BUG_IF_NOT() macro ci: add build checking for side-effects in assert() calls treewide: replace assert() with BUG_IF_NOT() in special cases
Nice, this version looks great to me. I left a couple of notes
throughout, but they range from "could be done later" to idle
commentary. Thanks for working on this, and I'm sorry to have sent you
down such a rabbit hole ;-).
Reviewed-by: Taylor Blau [off-list ref]
Thanks,
Taylor