Re: [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES
From: Phillip Wood <hidden>
Date: 2025-03-09 10:52:48
Possibly related (same subject, not in this thread)
- 2025-03-07 · Re: [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES · Junio C Hamano <hidden>
On 07/03/2025 15:07, Phillip Wood wrote:
On 07/03/2025 10:32, Phillip Wood wrote: The diff below stops us from building pack-redundant with -Dbreaking_changes=true but still builds the documentation. I don't intend spending any more time one this [...]
>
if get_option('breaking_changes')
build_options_config.set('WITH_BREAKING_CHANGES', 'YesPlease')
+ add_project_arguments('-DWITH_BREAKING_CHANGES=YesPlease', language :
'c')
Looking again at this I think it should probably be
libgit_c_args += '-DWITH_BREAKING_CHANGES=YesPlease'
to match the rest of our meson.build. As a newcomer to meson I find it
confusing that the CFLAGS for the build targets are set implicitly by
their libgit dependency.
Best Wishes
Phillip